Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhook event builder #248

Open
odolbeau opened this issue Sep 13, 2019 · 1 comment
Open

Add webhook event builder #248

odolbeau opened this issue Sep 13, 2019 · 1 comment
Assignees
@SecondeJK
Labels
enhancement

Comments

@odolbeau
Copy link

odolbeau commented Sep 13, 2019 •
edited

Would you consider a PR containing a WebhookEventBuilder class which will transform a JSON string to an Event?

List of webhooks events classes:

  • Archive
  • ConnectionCreated
  • ConnectionDestroyed
  • StreamCreated
  • StreamDestroyed

The stripe SDK propose something similar (but with a generic event class).
@SecondeJK
Copy link
Contributor

We have something similar to this in the Vonage PHP SDK Core (Comms APIs)
If the PR followed this pattern (which hydrates incoming webhooks via. PHP globals) then I'd be up for merging it

@SecondeJK SecondeJK self-assigned this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SecondeJK SecondeJK

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@odolbeau @SecondeJK