You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking at the source code of the FractionalBrownianMotionModel class, we can see that the two parameters constructors are defined as follows:
FractionalBrownianMotionModel(const Scalar scale,
const Scalar amplitude,
const Scalar exponent);
FractionalBrownianMotionModel(const Scalar scale,
const Point & amplitude,
const Point & exponent,
const SquareMatrix & eta,
const CorrelationMatrix & rho);
This choice is, first of all, not coherent with the API documentation which is only compatible with the second ctor.
Moreover, this is not coherent with other covariance models in the library, for which both scale and amplitude are Points by default, regardless of the input and output sizes.
Shall we maybe change the first ctor ?
How to reproduce the issue?
Look at the documentation and at the source code.
Version
1.23dev
Operating System
Linux
Installation media
conda
Additional Context
No response
The text was updated successfully, but these errors were encountered:
What happened?
Looking at the source code of the FractionalBrownianMotionModel class, we can see that the two parameters constructors are defined as follows:
This choice is, first of all, not coherent with the API documentation which is only compatible with the second ctor.
Moreover, this is not coherent with other covariance models in the library, for which both scale and amplitude are Points by default, regardless of the input and output sizes.
Shall we maybe change the first ctor ?
How to reproduce the issue?
Look at the documentation and at the source code.
Version
1.23dev
Operating System
Linux
Installation media
conda
Additional Context
No response
The text was updated successfully, but these errors were encountered: