Improve low discrepancy sequences #2654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mbaudin47
commented
May 12, 2024
•
mbaudin47
commented
- Improve unit test of Halton sequence
- Improve unit test of Faure sequence
- Improve unit test of Sobol' sequence
- Closes The Faure sequence is wrong #2653
mbaudin47
force-pushed
the
ldsunittests
branch
3 times, most recently
from
40ac801
to
f1067d7
Compare
mbaudin47
changed the title
jschueller
reviewed
May 14, 2024
jschueller
reviewed
May 14, 2024
jschueller
approved these changes
May 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2654 +/- ##
=======================================
Coverage 78.47% 78.48%
=======================================
Files 840 840
Lines 96641 96641
=======================================
+ Hits 75836 75844 +8
+ Misses 20805 20797 -8 ☔ View full report in Codecov by Sentry. |
mbaudin47
commented
May 15, 2024
regislebrun
approved these changes
May 16, 2024
| @@ -381,9 +381,9 @@ Unsigned64BitsInteger LowDiscrepancySequenceImplementation::GetNextPrimeNumber(c | |||
| #ifdef OPENTURNS_HAVE_PRIMESIEVE | |||
| primesieve::iterator it; | |||
| #if PRIMESIEVE_VERSION_MAJOR >= 11 | |||
| it.jump_to(n - 1); | |||
| it.jump_to(n); | |||
There was a problem hiding this comment.
Line 380, the test if (n == 0) return 2; should be replaced by if (n <= 2) return 2;
| expected3D[5] = Point({2.0 / 9.0, 8.0 / 9.0, 5.0 / 9.0}); | ||
| expected3D[6] = Point({5.0 / 9.0, 2.0 / 9.0, 8.0 / 9.0}); | ||
| expected3D[7] = Point({8.0 / 9.0, 5.0 / 9.0, 2.0 / 9.0}); | ||
| FaureSequence sequence3D(3); |
There was a problem hiding this comment.
Have you checked the values for larger samples, even if these values don't have to be checked in the test? This is just the beginning of the sequence and surprises can pop up for larger values...
|
|
good to go after the first Regis comment is addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.