New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit the number 4 from the make -sj4 recommendation #5473
Comments
Hi. It is news to me if/that |
I don't see the "based on the number of available CPU cores" part in the documentation. Where is that?
Do you want to implement this, @AlbertVeli? |
It was actually an assumption based on how it seemed to work. I should have checked before.
I can give it a try and see if it succeeds. |
One easy way would be to call ncores, from coreutils. It is not guaranteed to be installed everywhere though. But ncores if installed, else a default value of 4. What do you think of that? Edit. The tool from coreutils is called nproc, not ncores. |
We ended up going with "add our own detection of CPU count to include that number in the suggested command". So we can close this issue as completed, in that sense. |
When configuring john it finishes with:
But make -sj should, according to the documentation, automatically try to use as many jobs as possible, based on the number of available CPU cores. I tried it on macOS Ventura with 4 cores and on a Ubuntu 22.04 machine with 12 cores while running htop and it does indeed utilise all CPU cores on both machines when the number after j is omitted.
The text was updated successfully, but these errors were encountered: