Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework error handling #792

Open
oliwel opened this issue Nov 26, 2020 · 0 comments
Open

Rework error handling #792

oliwel opened this issue Nov 26, 2020 · 0 comments
Labels
4.x

Comments

@oliwel
Copy link
Contributor

oliwel commented Nov 26, 2020 •
edited

Bullet list what should be reworked - open for discussion

  • use different classes / subclasses for different errors, uses classes to catch and handle "special" errors
  • remove the old I18N strings
  • rework the format of errors on the socket API (the option to stack multiple messages is not used and makes handling on the client very complicated)
  • logger for OpenXPKI::Exception (logs to openxpki.system by default also in client scripts)
  • logger for WebUI (currently uses main), might be useful to have subcategories here too
  • logger for RPC/EST, might be useful to add endpoint to logger category
oliwel added a commit that referenced this issue Dec 1, 2020
@oliwel
Rework exception handling for validator errors
b23160f 
replace generic exception with string match on message with a dedicated
exception.
validation errors are now logged to application with prio debug
fixes validation error for async workflows
needs some cleanup/general abstraction, see also #792
oliwel added a commit that referenced this issue Dec 9, 2020
@oliwel
Rework exception handling for validator errors
ecfd086 
replace generic exception with string match on message with a dedicated
exception.
validation errors are now logged to application with prio debug
fixes validation error for async workflows
needs some cleanup/general abstraction, see also #792
@oliwel oliwel added the 4.x label May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oliwel