Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix assertion in Persistent L2ARC #16207

Merged
merged 1 commit into from
May 25, 2024
Merged

Fix assertion in Persistent L2ARC #16207

merged 1 commit into from
May 25, 2024

Conversation

gamanakis
Copy link
Contributor

@gamanakis gamanakis commented May 18, 2024 •
edited

At the end of l2arc_evict() fix an assertion in the case that
l2ad_hand + distance == l2ad_end.

Closes #16202

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@gamanakis
Fix assertion in Persistent L2ARC
edac0ed 
At the end of l2arc_evict() fix an assertion in the case that l2ad_hand
+ distance == l2ad_end.

Closes openzfs#16202

Signed-off-by: George Amanakis <gamanakis@gmail.com>
@gamanakis gamanakis marked this pull request as ready for review May 19, 2024 17:30
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label May 25, 2024
@behlendorf behlendorf merged commit 8865dfb into openzfs:master May 25, 2024
23 of 24 checks passed
gamanakis added a commit to gamanakis/zfs that referenced this pull request May 27, 2024
@gamanakis
Fix assertion in Persistent L2ARC
bcb8e94 
At the end of l2arc_evict() fix an assertion in the case that l2ad_hand
+ distance == l2ad_end.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes openzfs#16202
Closes openzfs#16207
@gamanakis gamanakis mentioned this pull request May 27, 2024
Merged
13 tasks
behlendorf pushed a commit that referenced this pull request May 29, 2024
@gamanakis @behlendorf
Fix assertion in Persistent L2ARC
2eab4f7 
At the end of l2arc_evict() fix an assertion in the case that l2ad_hand
+ distance == l2ad_end.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes #16202
Closes #16207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VERIFY3(dev->l2ad_hand + distance < dev->l2ad_end) failed
2 participants
@gamanakis @behlendorf