Skip to content
This repository has been archived by the owner on Oct 23, 2019. It is now read-only.

Make extending easier #140

Open
devinsba opened this issue Apr 26, 2017 · 1 comment
Open

Make extending easier #140

devinsba opened this issue Apr 26, 2017 · 1 comment

Comments

@devinsba
Copy link
Contributor

Right now we maintain as a group 2 different extension images, aws and azure, and I'm sure there are probably a few internal ones throughout the community. With the recent change to use spring-boot 1.5 we had to change the jar loading mechanism. This new mechanism doesn't require unpacking the jars anymore as they can be referenced directly by loader.path. This property is what I would expect we leverage.

This is its javadoc:

	/**
	 * Properties key for classpath entries (directories possibly containing jars or
	 * jars). Multiple entries can be specified using a comma-separated list. {@code
	 * BOOT-INF/classes,BOOT-INF/lib} in the application archive are always used.
	 */
	public static final String PATH = "loader.path";

Since it can take a directory that possibly includes jars, I think it would make sense to create a well known path that extensions can just drop their jars in and have it just work.

I'll file a PR with my idea when I get a free hour

@codefromthecrypt
Copy link

codefromthecrypt commented Apr 27, 2017 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants