You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One of our vertx projects using brave-instrumentation-vertx-web for tracing interceptor started breaking after upgrading to vert.x 4 , later realised that tracing interceptor is breaking as latest brave-instrumentation-vertx-web is not yet compatible with vertx 4.x
As vert.x 4.x has removed the following API io.vertx.core.http.HttpServerRequest.rawMethod(), there are breaking changes with vertx 4.x upgrade, one of them being -
java.lang.NoSuchMethodError: 'java.lang.String io.vertx.core.http.HttpServerRequest.rawMethod()'
at brave.vertx.web.TracingRoutingContextHandler$HttpServerRequestWrapper.method(TracingRoutingContextHandler.java:95)
at brave.http.HttpRequestParser$Default.spanName(HttpRequestParser.java:80)
at brave.http.HttpRequestParser$Default.parse(HttpRequestParser.java:69)
at brave.http.HttpHandler.parseRequest(HttpHandler.java:58)
at brave.http.HttpServerHandler.parseRequest(HttpServerHandler.java:143)
at brave.http.HttpHandler.handleStart(HttpHandler.java:40)
at brave.http.HttpServerHandler.handleReceive(HttpServerHandler.java:112)
at brave.vertx.web.TracingRoutingContextHandler.handle(TracingRoutingContextHandler.java:57)
at brave.vertx.web.TracingRoutingContextHandler.handle(TracingRoutingContextHandler.java:38)
at io.vertx.ext.web.impl.RouteState.handleFailure(RouteState.java:1273)
at io.vertx.ext.web.impl.RoutingContextImplBase.iterateNext(RoutingContextImplBase.java:160)
at io.vertx.ext.web.impl.RoutingContextImpl.next(RoutingContextImpl.java:141)
at io.vertx.ext.web.impl.RoutingContextImpl.doFail(RoutingContextImpl.java:543)
at io.vertx.ext.web.impl.RoutingContextImpl.fail(RoutingContextImpl.java:192)
at io.vertx.ext.web.impl.RoutingContextImpl.fail(RoutingContextImpl.java:181)
at io.vertx.ext.web.impl.RoutingContextImplBase.handleInHandlerRuntimeFailure(RoutingContextImplBase.java:199)
at io.vertx.ext.web.impl.RoutingContextImplBase.iterateNext(RoutingContextImplBase.java:168)
at io.vertx.ext.web.impl.RoutingContextImpl.next(RoutingContextImpl.java:141)
at io.vertx.ext.web.impl.RouterImpl.handle(RouterImpl.java:72)
at io.vertx.ext.web.impl.RouterImpl.handle(RouterImpl.java:37)
at io.vertx.core.http.impl.Http1xServerRequestHandler.handle(Http1xServerRequestHandler.java:67)
at io.vertx.core.http.impl.Http1xServerRequestHandler.handle(Http1xServerRequestHandler.java:30)
at io.vertx.core.impl.EventLoopContext.emit(EventLoopContext.java:56)
at io.vertx.core.impl.DuplicatedContext.emit(DuplicatedContext.java:174)
at io.vertx.core.http.impl.Http1xServerConnection.handleMessage(Http1xServerConnection.java:145)
at io.vertx.core.net.impl.ConnectionBase.read(ConnectionBase.java:155)
at io.vertx.core.net.impl.VertxHandler.channelRead(VertxHandler.java:153)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
at io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:93)
at io.netty.handler.codec.http.websocketx.extensions.WebSocketServerExtensionHandler.channelRead(WebSocketServerExtensionHandler.java:99)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
at io.vertx.core.http.impl.Http1xUpgradeToH2CHandler.channelRead(Http1xUpgradeToH2CHandler.java:116)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:327)
at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:314)
at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:435)
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:279)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
at io.vertx.core.http.impl.Http1xOrH2CHandler.end(Http1xOrH2CHandler.java:61)
at io.vertx.core.http.impl.Http1xOrH2CHandler.channelRead(Http1xOrH2CHandler.java:38)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919)
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:722)
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:658)
at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:584)
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:496)
at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:986)
at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
at java.base/java.lang.Thread.run(Thread.java:829)
Expected Behaviour
Need to make brave-instrumentation-vertx-web compatible with vertx 4 as vertx 3.x has unfixed CVEs
The text was updated successfully, but these errors were encountered:
Description
One of our vertx projects using brave-instrumentation-vertx-web for tracing interceptor started breaking after upgrading to vert.x 4 , later realised that tracing interceptor is breaking as latest brave-instrumentation-vertx-web is not yet compatible with vertx 4.x
As vert.x 4.x has removed the following API io.vertx.core.http.HttpServerRequest.rawMethod(), there are breaking changes with vertx 4.x upgrade, one of them being -
Expected Behaviour
Need to make brave-instrumentation-vertx-web compatible with vertx 4 as vertx 3.x has unfixed CVEs
The text was updated successfully, but these errors were encountered: