Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spring-webmvc for jakarta #1369

Open
be-hase opened this issue Apr 27, 2023 · 3 comments
Open

Support spring-webmvc for jakarta #1369

be-hase opened this issue Apr 27, 2023 · 3 comments

Comments

@be-hase
Copy link

be-hase commented Apr 27, 2023

There is a change from spring boot3 (spring 6) to jakarta.servlet.

Currently, brave-instrumention-spring-webmvc only supports javax.servlet.

Are there any plans to support jakarta.servlet?

In the long run, I think spring users would be better off with micrometer tracing, but I think existing users would be happier with brave-instrumention-spring-webmvc as well.

@marcingrzejszczak
Copy link
Contributor

Spring mvc natively supports micrometer observation. They work with micrometer tracing which has a brave bridge.

@reta
Copy link
Contributor

reta commented Aug 24, 2023

On the side note

Are there any plans to support jakarta.servlet?

It is supported already https://github.com/openzipkin/brave/tree/master/instrumentation/servlet-jakarta

@be-hase
Copy link
Author

be-hase commented Aug 24, 2023

It is supported already https://github.com/openzipkin/brave/tree/master/instrumentation/servlet-jakarta

servlet-jakarta is coresspond to servlet, not the jakarta version of spring-webmvc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants