Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for "finished span handler" #90

Open
jcchavezs opened this issue Nov 7, 2018 · 1 comment · May be fixed by #135
Open

Adds support for "finished span handler" #90

jcchavezs opened this issue Nov 7, 2018 · 1 comment · May be fixed by #135

Comments

@jcchavezs
Copy link
Contributor

There are some cases where one might need to enable/disable tracing for certain children spans. For example, if I will write a bunch of files in a zip stream, I want to trace the call to S3 to list the files but not every single call to S3 to retrieve the content of the file. In such case I want to make a decision on what to record and what not based on rules in the spans.

For implementation reference we could have a look at brave: https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/handler/FinishedSpanHandler.java

Ping @basvanbeek @adriancole

@basvanbeek
Copy link
Member

FinishedSpanHandler would also allow for a solution to #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants