Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X-Forwarded-For in Public/Private Frontends #609

Closed
michaelquigley opened this issue Apr 30, 2024 · 2 comments
Closed

X-Forwarded-For in Public/Private Frontends #609

michaelquigley opened this issue Apr 30, 2024 · 2 comments
Labels
enhancement Enhancement of an existing feature
Milestone
v0.4

Comments

@michaelquigley
Copy link
Collaborator

michaelquigley commented Apr 30, 2024 •
edited

The public/private frontends should set X-Fowarded-For and friends when they're not set in the HTTP request.
@michaelquigley michaelquigley added the enhancement Enhancement of an existing feature label Apr 30, 2024
@michaelquigley michaelquigley added this to the v0.4 milestone Apr 30, 2024
michaelquigley added a commit that referenced this issue Apr 30, 2024
@michaelquigley
add 'no_forwarder' configuration option to the frontend configuration…
f889380 
… to avoid adding x-forwarded-for (#609)
@michaelquigley michaelquigley mentioned this issue Apr 30, 2024
Open
@qrkourier
Copy link
Member

Tangentially related comment about the x-forwarded-host host header we decided not to support in the frontend: #492 (comment)

@michaelquigley
Copy link
Collaborator Author

This is already implemented and working well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement of an existing feature
Projects
zrok Development Roadmap
Status: Done
Milestone
v0.4
Development

No branches or pull requests
2 participants
@qrkourier @michaelquigley