Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation to override or adding Helm values #152

Open
SimonBaeumer opened this issue Feb 19, 2022 · 5 comments
Open

Add annotation to override or adding Helm values #152

SimonBaeumer opened this issue Feb 19, 2022 · 5 comments
Labels
triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@SimonBaeumer
Copy link
Member

SimonBaeumer commented Feb 19, 2022

Sometimes it is necessary to override Helm values which are not set by the Operator if used with a Custom Resource.

In our case the custom resource abstracts the Helm values and differentiates. Nevertheless our Helm charts provides more options than the CR thus necessary to add overrides to adjust Helm values directly (or disabling auto-sensing for specific values).

Proposal

Add operators.operatorframework.io.helm-operator-plugins.value-override/path.to.helm.key=value annotation which overrides the value.

Optional adding an option which disables this annotation to override Helm values.

@asmacdo asmacdo added the triage/needs-information Indicates an issue needs more information in order to work on it. label Feb 22, 2022
@asmacdo
Copy link
Member

asmacdo commented Feb 22, 2022

We are wondering why we would need to take this path, rather than simply adding these values to the CRD?

@joelanford suggested that the operator author could make use of the value translator interface, so custom annotations can be read by the operator that way, but it we will need a good use case to accept this in the helm plugin.

@jmrodri
Copy link
Member

jmrodri commented Mar 8, 2022

@SimonBaeumer @asmacdo any other information on this issue?

@asmacdo
Copy link
Member

asmacdo commented Apr 28, 2022

I'm going to close for now, please reopen if this is still needed.

@asmacdo asmacdo closed this as completed Apr 28, 2022
@SimonBaeumer
Copy link
Member Author

This is necessary when a Helm chart has more options than the operator's CRD. This happens often when an existing Helm chart is used to install the operand.
Today we faced an incident where we needed to pause the reconciler and adjust k8s resources manually for a timeout change which was not exposed in the CRD.

For us the difference is mostly that this is a break-glass mechanism used for support & cloud teams to implement hot-fixes without a new operator image.

@SimonBaeumer
Copy link
Member Author

@asmacdo Can you reopen this issues please?

@asmacdo asmacdo reopened this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

3 participants