feat: optional dependent resource #2240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
force-pushed
the
optional-dependent
branch
from
8c0b66b
to
a308146
Compare
|
For customizing the expiration mechanism there will be a separate PR. |
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com> Signed-off-by: Attila Mészáros <csviri@gmail.com>
* feat: move name is directly to dependent resource - use this name when throwing aggregate exception Signed-off-by: Attila Mészáros <csviri@gmail.com> * refactor to use a dedicated interface for setting the name Signed-off-by: Attila Mészáros <csviri@gmail.com> * refactor: add default implementation for name() (#2255) Signed-off-by: Chris Laprun <claprun@redhat.com> Signed-off-by: Attila Mészáros <csviri@gmail.com> --------- Signed-off-by: Attila Mészáros <csviri@gmail.com> Signed-off-by: Chris Laprun <claprun@redhat.com> Co-authored-by: Chris Laprun <metacosm@users.noreply.github.com> Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
force-pushed
the
optional-dependent
branch
from
17004b3
to
cdce182
Compare
openshift-merge-robot
removed
the
needs-rebase
metacosm
requested changes
Mar 12, 2024
...n/java/io/javaoperatorsdk/operator/processing/dependent/workflow/DefaultManagedWorkflow.java
Show resolved
Hide resolved
| package io.javaoperatorsdk.operator.processing.expiration; | ||
|
|
||
|
|
||
| public interface Expiration { |
There was a problem hiding this comment.
Why do we need an interface for this? Do we envision multiple implementations?
There was a problem hiding this comment.
This is same principle as for retry, some might be able different strategy, so created an abstraction for that.
| @@ -0,0 +1,9 @@ | |||
| package io.javaoperatorsdk.operator.processing.expiration; | |||
|
|
|||
| public interface ExpirationExecution { | |||
There was a problem hiding this comment.
Same comment than for Expiration.
| import io.javaoperatorsdk.operator.processing.retry.GenericRetry; | ||
| import io.javaoperatorsdk.operator.processing.retry.Retry; | ||
|
|
||
| public class CRDPresentActivationCondition implements Condition<HasMetadata, HasMetadata> { |
There was a problem hiding this comment.
I think this should be better implemented as a utilty class that could be reused elsewhere and shared across reconcilers, in particular because Controller also can check the availability of the CRD so it would be better if the same logic / implementation / cache could be reused/shared everywhere this functionality is needed.
There was a problem hiding this comment.
Yes, that is true, I don't like utilities / static scoped states, usually, those lead to problems (eventually). But will think about how to handle that.
csviri
force-pushed
the
optional-dependent
branch
from
cdce182
to
422224d
Compare
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
…2308) Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
force-pushed
the
optional-dependent
branch
from
422224d
to
daf2262
Compare
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
Signed-off-by: Chris Laprun <claprun@redhat.com>
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
csviri
force-pushed
the
next
branch
3 times, most recently
from
afe3d7d
to
cc57156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.