Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ControllerConfiguration annotation optional #2279

Open
metacosm opened this issue Mar 11, 2024 · 1 comment · May be fixed by #2412
Open

Make the ControllerConfiguration annotation optional #2279

metacosm opened this issue Mar 11, 2024 · 1 comment · May be fixed by #2412
Milestone

Comments

@metacosm
Copy link
Collaborator

With workflows being moved to their own annotation, it might often happen that the ControllerConfiguration ends up being empty. It would be nice if it could be made optional.

Originally posted by @csviri in #2274 (comment)

@metacosm
Copy link
Collaborator Author

Note that, if I recall properly, we already looked at making it optional at some point but ran into some issues (though I don't remember which ones).
Note also that the annotation is already optional when you use the Quarkus extension because the processing is based on whether or not a class implements the Reconciler interface there.

@metacosm metacosm added this to the 5.0 milestone Mar 12, 2024
@csviri csviri linked a pull request May 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant