Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Release - Proper Tagging #2304

Open
csviri opened this issue Mar 21, 2024 · 1 comment
Open

Improve Release - Proper Tagging #2304

csviri opened this issue Mar 21, 2024 · 1 comment

Comments

@csviri
Copy link
Collaborator

csviri commented Mar 21, 2024

We discovered that during the release the tag that we create contains wrong version (the actual not the target release version), this does not make any functional problems, the code is the proper one, just the project version is set after GitHub Action receives the event, but the tag is already created that time.

@csviri
Copy link
Collaborator Author

csviri commented Mar 21, 2024

One solution would be just simply tag the code during the release process, and replace the tag associated with the release with a proper one.

It is really nice now, that the release is bound the the event of actually creating a release in GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant