Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can configmap-server support v1 crd? #1108

Open
AllenZMC opened this issue Jun 8, 2023 · 2 comments
Open

Can configmap-server support v1 crd? #1108

AllenZMC opened this issue Jun 8, 2023 · 2 comments
Labels
triage/unresolved Indicates an issue that can not or will not be resolved.

Comments

@AllenZMC
Copy link

AllenZMC commented Jun 8, 2023

Can configmap-server continue to be used in the next few versions?

I see that crd only supports v1beta1, can it support v1?

func (c *ConfigMapLoader) Populate() error {
	c.log.Info("loading CRDs")

	// first load CRDs into memory; these will be added to the bundle that owns them
	crdListYaml, ok := c.configMapData[ConfigMapCRDName]
	if !ok {
		return fmt.Errorf("couldn't find expected key %s in configmap", ConfigMapCRDName)
	}

	crdListJson, err := yaml.YAMLToJSON([]byte(crdListYaml))
	if err != nil {
		c.log.WithError(err).Debug("error loading CRD list")
		return err
	}

      
	var parsedCRDList []v1beta1.CustomResourceDefinition
	if err := json.Unmarshal(crdListJson, &parsedCRDList); err != nil {
		c.log.WithError(err).Debug("error parsing CRD list")
		return err
	}
@AllenZMC AllenZMC changed the title Can configmap-server continue to be used in the next few versions? Can configmap-server continue to be used in the next few versions? Jun 8, 2023
@AllenZMC AllenZMC changed the title Can configmap-server continue to be used in the next few versions? Can configmap-server support v1 crd? Jun 9, 2023
@AllenZMC
Copy link
Author

AllenZMC commented Jun 9, 2023

@awgreene

@everettraven

@grokspawn
Copy link
Contributor

Hi @AllenZMC . Since SQLite-format catalogs are being deprecated configmap-server is a deprecated command, but we haven't done a good job of communicating that. I've created #1112 to track doing a better job of communicating status for this command. We would be happy to review PRs on the content, but do not have any plans to implement new features for deprecated commands.

@grokspawn grokspawn added the triage/unresolved Indicates an issue that can not or will not be resolved. label Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/unresolved Indicates an issue that can not or will not be resolved.
Projects
None yet
Development

No branches or pull requests

2 participants