-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tool allow users choose between --project-version "2" or "3-alpha" #3674
Comments
Hi @joelanford, @estroz, Probably we might be able to check/address it after 1.0, however, in POV it is valid just think a little about it and the possible impacts of this change after 1.0 to make sure that everything is fine. |
Users should be able to choose between the two supported project versions. Until project version 2 is deprecated, |
Hi @estroz, Sorry, I think you misunderstood the concern raised here. The point is that in upstream when we choose
So my concerns relevant for 1.0 are: if we have the intention to add v3-alpha plugin for sdk and have both tools aligned:
PS.: in POV we can align both and have an sdk-v3-alpha plugin as well which will be based in the v3-alpha-kb plugin, the default plugin should be the stable instead and of the alpha one and it is fine to be done after 1.0 which means that in this case this task would be kept open add assign to another milestone. I hope that it clarifies my concerns. WDYT @joelanford |
@estroz @camilamacedo86 can you clarify one thing for me? My understanding is:
Is this understanding correct? |
Hi @joelanford and @estroz OK. I also re-checked all to see if I am not missing the boat in anything here. See
If we run SDK == KB
If we run SDK != KB
PS.: I am unable to gen with version 2 in sdk with the master branch: See: #3690 Regards my comments over v3-alpha plugin: I was missing the boat since KB do NOT use the So, the only think that we need to do in this task is after fix #3690 ensure that if we run
Am I right? |
I use plugin phase to differentiate the current phase 1 plugins from future phase 2 plugins, which we have implemented as post-plugin modifiers (manifests, scorecard) in a forwards-compatible way under the |
Hi @estroz, @joelanford The following one is not supportable by SDK just for KB currently. Am I right? Would we like to support it as well as post 1.0?
Regards the project-version=2:
|
I understand that the scenario project-version=2 will be solved with https://github.com/kubernetes-sigs/kubebuilder/pull/1628/files 👍 |
Closed by #3697 |
The tool allows users to choose between
--project-version "2" or "3-alpha"
, however, both will perform the same GO v2 plugin scaffold. The only diff between both is the project name that is added to the PROJECT file now because of what was done in kubernetes-sigs/kubebuilder#1611 which would be valid just for v3-alpha.3-alpha
project-version scaffold the project with SDK plugin alpha based on the default upstream Go plugin for 3-alpha?The text was updated successfully, but these errors were encountered: