Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command run packagemanifests creates a new operatorgroup even if one already exists #3681

Closed
joelanford opened this issue Aug 7, 2020 · 0 comments · Fixed by #3689
Closed
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Milestone

Comments

@joelanford
Copy link
Member

Bug Report

What did you do?
Used kubectl operator to install an operator from the community operators catalog in the default namespace. This resulted in a default operator group being created.

Then I ran operator-sdk run packagemanifests --version=0.1.0 with a local project. This resulted in another operator group being created, called operator-sdk-og

What did you expect to see?
I expected the operator-sdk run packagemanifests command to detect the existing operator group, verify compatibility with the install mode being used, and then just skip creation of the operator-sdk-og operator group

What did you see instead? Under which circumstances?
Two operator groups present in the same namespace, which is invalid. This resulted in the run packagemanifests command failing because the CSV was never installed. It also caused the kubectl operator installed operator to fail.

Environment

  • operator-sdk version:

operator-sdk version: "v1.0.0-alpha.2-19-g4739c1fc", commit: "4739c1fc5bfb61db28b1bc52b66a63d9493a1ec2", kubernetes version: "v1.18.2", go version: "go1.13.10 linux/amd64", GOOS: "linux", GOARCH: "amd64"

  • go version:

go version go1.13.10 linux/amd64

  • Kubernetes version information:

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.6", GitCommit:"dff82dc0de47299ab66c83c626e08b245ab19037", GitTreeState:"clean", BuildDate:"2020-07-15T16:58:53Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T11:48:36Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

  • Kubernetes cluster kind: minikube --driver=none

  • Are you writing your operator in ansible, helm, or go? helm (but I think applicable to all operator types)

Possible Solution
Skip operator Group creation if an operator group already exists in the namespace

Additional context
Add any other context about the problem here.

@joelanford joelanford added this to the v1.0.0 milestone Aug 7, 2020
@joelanford joelanford assigned joelanford and estroz and unassigned joelanford Aug 7, 2020
@estroz estroz added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Aug 7, 2020
@joelanford joelanford modified the milestones: v1.0.0, v1.1.0 Aug 10, 2020
@joelanford joelanford added the kind/bug Categorizes issue or PR as related to a bug. label Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants