Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all fragment arguments, activity intent extras, and saved instance state over to protos #4986

Open
BenHenning opened this issue May 17, 2023 · 0 comments · May be fixed by #5248
Open
Assignees
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.

Comments

@BenHenning
Copy link
Sponsor Member

BenHenning commented May 17, 2023

Is your feature request related to a problem? Please describe.
Bundles do not provide strong typing or presence guarantees, and require unique strings to identify per-fragment and per-activity values.

Describe the solution you'd like
Protos help alleviate this problem and can be serialized directly into bundles. Protos also allow for more trivial composition (e.g. when passing data from fragments to activities), and eventually can simplify both data processing (#1051) and on-disk storage (e.g. in the case of #2571), though the latter is less important since Android already serializes bundles on-disk. This will also help with the mechanisms needed for #309 to be possible.

The solution here is to move all fragment arguments, activity extras, and saved instance state bundle usage over to using protos entirely.

Describe alternatives you've considered
The only other obvious solution is to continue with bundles and not solve the original problem that's mentioned. There are other possible serialization intermediaries we could consider (such as JSON), but protos make the most sense given that they're already used broadly in the codebase.

Additional context
None.

@BenHenning BenHenning changed the title Move all fragment arguments & activity intent extras over to protos Move all fragment arguments, activity intent extras, and saved instance state over to protos May 17, 2023
@MohitGupta121 MohitGupta121 added Impact: Low Low perceived user impact (e.g. edge cases). enhancement End user-perceivable enhancements. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Jun 16, 2023
@Vishwajith-Shettigar Vishwajith-Shettigar self-assigned this Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet.
4 participants