Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos + StringFormatCount + UnusedQuantit + AllowBackup #5272

Open
Tracked by #5169
adhiamboperes opened this issue Dec 14, 2023 · 7 comments
Open
Tracked by #5169

Typos + StringFormatCount + UnusedQuantit + AllowBackup #5272

adhiamboperes opened this issue Dec 14, 2023 · 7 comments
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@adhiamboperes
Copy link
Collaborator

adhiamboperes commented Dec 14, 2023

Description

We would like to fix all the remaining lint issues on Oppia Android in the "Typos + StringFormatCount + UnusedQuantit + AllowBackup" categories.

Steps To Reproduce

Run the following command from a terminal in a checked-out Oppia Android repo:

./gradlew :app:lint

Expected Behavior

Running the command above should not show any errors in this category

@adhiamboperes
Copy link
Collaborator Author

adhiamboperes commented Dec 14, 2023

Hi @deonwaju, on the OK button capitalization, please refer to the discussion in #5194. @Rd4dev has an open PR that fixes this. Please check if there is any other flagged typo.

You can look into the solutions for the other items in the issue.

Re: #5169 (comment). The solution for ratio sounds ok to me.

@adhiamboperes adhiamboperes added good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). bug End user-perceivable behaviors which are not desirable. Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Dec 14, 2023
@deonwaju
Copy link
Collaborator

Hello @adhiamboperes,

  1. Fix for Typos: Found an extra typo which is the "Repeated word "dois" in message: possible typo" in pt-rBR/strings.xml: line 177

@deonwaju
Copy link
Collaborator

Hello @adhiamboperes ,

For AllowBackup issue,
Solutions are to either turn allowbackup to false in the manifest or create a backup.xml file and exclude GCM Registration ID from it. I would need help to find or know where the GCM Registration ID is on the repo.

@deonwaju
Copy link
Collaborator

deonwaju commented Dec 21, 2023

Fix for UnusedQuantity: Solutions are to
remove quantity zero from pt-rBR/strings.xml: line 208 []
Do the same for line 203

Before:

Screenshot 2024-01-20 at 21 07 05

After:

Screenshot 2024-01-20 at 22 09 41

@deonwaju
Copy link
Collaborator

deonwaju commented Jan 20, 2024

@adhiamboperes, please review last comments so i can proceed.

@adhiamboperes
Copy link
Collaborator Author

@deonwaju, sounds good.

@adhiamboperes
Copy link
Collaborator Author

Hello @adhiamboperes ,

For AllowBackup issue, Solutions are to either turn allowbackup to false in the manifest or create a backup.xml file and exclude GCM Registration ID from it. I would need help to find or know where the GCM Registration ID is on the repo.

For this one, hold off on it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Development

No branches or pull requests

2 participants