Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Add a "hint/solution viewed" event to complement the existing "offered"/"unlocked" events. #5069

Open
seanlip opened this issue Jun 19, 2023 · 5 comments · May be fixed by #5298
Open

[Feature Request]: Add a "hint/solution viewed" event to complement the existing "offered"/"unlocked" events. #5069

seanlip opened this issue Jun 19, 2023 · 5 comments · May be fixed by #5298
Assignees
@Vishwajith-Shettigar
Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@seanlip
Copy link
Member

seanlip commented Jun 19, 2023

Is your feature request related to a problem? Please describe.
We currently have two events for each of hints and solutions, which state:

  • When the hint/solution was first offered
  • When the hint/solution was first unlocked

Describe the solution you'd like
The aim of this issue is to add a third "hint/solution viewed" event, to handle the case where the learner refers to a hint after initially unlocking it. Unlike the other two events, this event can trigger more than once for each hint/solution (the other two only trigger at most once in an "exploration session").

The first view of a hint/solution (immediately after it has been unlocked) should count as a view here.

If possible, it would be nice to also send the view_count with the "hint/solution viewed" event (e.g. is this the first view, the second view, the fifth view, etc.) but this is optional.

Describe alternatives you've considered
N/A
@seanlip seanlip added enhancement End user-perceivable enhancements. triage needed and removed triage needed labels Jun 19, 2023
@Chandra-Mauli-Sharma
Copy link

@seanlip I would like to work on this. Can you please assign this issue to me.

@adhiamboperes
Copy link
Collaborator

@Chandra-Mauli-Sharma This issue does require a bit of knowledge about this code base, but if you can provide a brief description of how you would go about it, we can assign it to you.

My recommendation though, would be to pick an issue from here that is not currently assigned to someone.

@MohitGupta121 MohitGupta121 added Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Jun 26, 2023
@adhiamboperes adhiamboperes added Work: Low Solution is clear and broken into good-first-issue-sized chunks. and removed Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Sep 30, 2023
@Vishwajith-Shettigar Vishwajith-Shettigar self-assigned this Jan 13, 2024
@Vishwajith-Shettigar Vishwajith-Shettigar linked a pull request Jan 13, 2024 that will close this issue
Open
6 tasks
@Vishwajith-Shettigar
Copy link
Collaborator

Hi @seanlip, can you please look at this screen recording and tell me if I am going right?

hintandsolutionviews.webm

@adhiamboperes
Copy link
Collaborator

@Vishwajith-Shettigar, this LGTM.

@Vishwajith-Shettigar
Copy link
Collaborator

Thank you @adhiamboperes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vishwajith-Shettigar Vishwajith-Shettigar

Labels
enhancement End user-perceivable enhancements. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Status: Todo
Milestone
No milestone
5 participants
@seanlip @adhiamboperes @Chandra-Mauli-Sharma @Vishwajith-Shettigar @MohitGupta121