New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full interaction response tooltip misplaced for graph input interaction (and the image doesn't show up) #13699
Comments
Hi @AdityaDubey0 Are you still workiing on this issue ? |
Hello @seanlip @SubhashThenua ! In addition to this, the graph SVG is not appearing at all (print from production environment). I would like to suggest that a new issue is openned, in order to solve this problem, since this one only refers to the misplaced tooltip. |
Thanks @ana-mc-almeida! I think we need to know more about what code you changed and what was causing the original bug. Thanks also for noticing that the tooltip image is not showing up. I think this needs to be fixed as part of this, actually, since there's not much point making the tooltip fix without it. Could you please look into it too? I will update the issue title. Thanks! |
Hello @seanlip, I managed to find out why the image wasn't showing up (and fix it). Here's an image with the final result of my changes: Regarding the code changes I had to make, they were as follows:
These were all the changes I made to the code to fix this issue. Let me know if I can help with anything else! |
Great, thanks @ana-mc-almeida, I'll assign you! When can you create a PR? Also, one note -- when you provide the "proof of changes" video, please verify that the answer display looks fine for all other interaction types as well (drag-and-drop, number, interactive map, etc.) -- I'm not sure which show a tooltip and which don't, but we should make sure that your changes don't break anything since they apply to generalized components. You can load the all_interactions exploration from /admin > Activities in your dev server (I think the exp ID is '16') and play through it, that should cover most of them. Thanks! |
Hi @seanlip, thanks for your help, I will verify the answer display in all the others interactions types. I intend to create the PR as soon as possible. I'm currently having difficulties creating a test that verifies that the graph image is being displayed in the popup, but once it's done I'll create the PR. |
Describe the bug
The full interaction response tooltip is not alligned with the short interaction response that the user clicks on to show the tooltip
To Reproduce
Steps to reproduce the behavior:
Observed behavior
The tooltip is not aligned with the previous answer that the user clicked on. (EDIT: note that the image also doesn't show up, see #13699 (comment) too):
Expected behavior
The tooltip should be aligned.
Desktop (please complete the following information; delete this section if the issue does not arise on desktop):
The text was updated successfully, but these errors were encountered: