From 8f229c68c82e10170dce6680ff6d1b21ae51c8a9 Mon Sep 17 00:00:00 2001 From: Jason Karns Date: Wed, 6 May 2020 13:25:19 -0400 Subject: [PATCH] Configure repository.directory for monorepo packages This is the standard configuration value for deep-linking into a package's directory within a monorepo. npm RFC: https://github.com/npm/rfcs/blob/latest/implemented/0010-monorepo-subdirectory-declaration.md This will ensure the packages' pages on npmjs.org will link to the correct directory. Also, _eventually_, it will ensure the `npm repo` command opens to the correct location: https://github.com/npm/cli/pull/163 Lastly, this is _required_ for monorepo packages to be successfully published to the GitHub Package Registry (if that is ever considered in the future). https://help.github.com/en/packages/using-github-packages-with-your-projects-ecosystem/configuring-npm-for-use-with-github-packages#publishing-multiple-packages-to-the-same-repository --- packages/datafile-manager/package.json | 5 +++++ packages/event-processor/package.json | 3 ++- packages/logging/package.json | 3 ++- packages/optimizely-sdk/package.json | 3 ++- packages/utils/package.json | 3 ++- 5 files changed, 13 insertions(+), 4 deletions(-) diff --git a/packages/datafile-manager/package.json b/packages/datafile-manager/package.json index be468c53b..d77a6ba0d 100644 --- a/packages/datafile-manager/package.json +++ b/packages/datafile-manager/package.json @@ -2,6 +2,11 @@ "name": "@optimizely/js-sdk-datafile-manager", "version": "0.5.0", "description": "Optimizely Full Stack Datafile Manager", + "repository": { + "type": "git", + "url": "git+https://github.com/optimizely/javascript-sdk.git", + "directory": "packages/datafile-manager" + }, "license": "Apache-2.0", "engines": { "node": ">=6.0.0" diff --git a/packages/event-processor/package.json b/packages/event-processor/package.json index 7bfd023dd..8456656c9 100644 --- a/packages/event-processor/package.json +++ b/packages/event-processor/package.json @@ -25,7 +25,8 @@ }, "repository": { "type": "git", - "url": "git+https://github.com/optimizely/javascript-sdk.git" + "url": "git+https://github.com/optimizely/javascript-sdk.git", + "directory": "packages/event-processor" }, "keywords": [ "optimizely" diff --git a/packages/logging/package.json b/packages/logging/package.json index 06617ffb0..c0f5f0bd3 100644 --- a/packages/logging/package.json +++ b/packages/logging/package.json @@ -25,7 +25,8 @@ }, "repository": { "type": "git", - "url": "git+https://github.com/optimizely/javascript-sdk.git" + "url": "git+https://github.com/optimizely/javascript-sdk.git", + "directory": "packages/logging" }, "keywords": [ "optimizely" diff --git a/packages/optimizely-sdk/package.json b/packages/optimizely-sdk/package.json index f0751fea2..be0a500e4 100644 --- a/packages/optimizely-sdk/package.json +++ b/packages/optimizely-sdk/package.json @@ -21,7 +21,8 @@ }, "repository": { "type": "git", - "url": "git+https://github.com/optimizely/javascript-sdk.git" + "url": "git+https://github.com/optimizely/javascript-sdk.git", + "directory": "packages/optimizely-sdk" }, "license": "Apache-2.0", "engines": { diff --git a/packages/utils/package.json b/packages/utils/package.json index 82c1c0b4e..b44ec0b15 100644 --- a/packages/utils/package.json +++ b/packages/utils/package.json @@ -25,7 +25,8 @@ }, "repository": { "type": "git", - "url": "git+https://github.com/optimizely/javascript-sdk.git" + "url": "git+https://github.com/optimizely/javascript-sdk.git", + "directory": "packages/utils" }, "keywords": [ "optimizely"