Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirm pagination on all list call #97

Open
joekr opened this issue May 25, 2022 · 1 comment · May be fixed by #283
Open

Confirm pagination on all list call #97

joekr opened this issue May 25, 2022 · 1 comment · May be fixed by #283
Assignees
@PreethamBojja
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@joekr
Copy link
Member

joekr commented May 25, 2022 •
edited

What would you like to be added:
We need this to run through all pages and return the full list of running instances https://github.com/oracle/cluster-api-provider-oci/blob/main/cloud/scope/machine_pool.go#L158

Also should check all other list calls are using pagination.

Why is this needed:
As clusters grow we want to make sure we don't miss running instances.
@joekr joekr added the enhancement New feature or request label May 25, 2022
@joekr joekr self-assigned this May 25, 2022
@joekr joekr changed the title Add pagination to instance list call Confirm pagination on all list call May 25, 2022
@joekr
Copy link
Member Author

joekr commented May 25, 2022 •
edited

checks indicate complete

compute

  • ListInstances
  • ListVnicAttachments

compute management

  • ListInstancePools
  • ListInstancePoolInstances
  • ListInstanceConfigurations - currently not used

identity

  • ListRegions
  • ListFaultDomains
  • ListAvailabilityDomains

Identity calls do not support pagination

network load balancer

  • ListNetworkLoadBalancers

vcn

  • ListVcns
  • ListSubnets
  • ListRouteTables
  • ListSecurityLists
  • ListInternetGateways
  • ListNatGateways
  • ListServiceGateways
  • ListServices
  • ListNetworkSecurityGroups
  • ListNetworkSecurityGroupSecurityRules
  • ListDrgs
  • ListDrgAttachments
  • ListRemotePeeringConnections

@joekr joekr mentioned this issue May 26, 2022
Closed
@joekr joekr added the good first issue Good for newcomers label Sep 9, 2022
@joekr joekr removed their assignment Sep 13, 2022
@PreethamBojja PreethamBojja mentioned this issue Apr 26, 2023
Merged
@PreethamBojja PreethamBojja linked a pull request Jun 11, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PreethamBojja PreethamBojja

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added pagination for list calls PreethamBojja/cluster-api-provider-oci
2 participants
@joekr @PreethamBojja