Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added pagination for list calls #283

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

feat: added pagination for list calls #283

wants to merge 15 commits into from

Conversation

PreethamBojja
Copy link
Contributor

@PreethamBojja PreethamBojja commented Jun 11, 2023 •
edited

What this PR does / why we need it:
Pagination for list calls

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #97

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 11, 2023
@PreethamBojja
Copy link
Contributor Author

unit tests

?   	github.com/oracle/cluster-api-provider-oci	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/api/v1beta1	34.879s	coverage: 24.1% of statements
ok  	github.com/oracle/cluster-api-provider-oci/api/v1beta2	1.657s	coverage: 15.8% of statements
?   	github.com/oracle/cluster-api-provider-oci/cloud/config	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/metrics	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/cloud/ociutil	0.323s	coverage: 19.6% of statements
ok  	github.com/oracle/cluster-api-provider-oci/cloud/scope	242.974s	coverage: 75.6% of statements
?   	github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/base	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/compute	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement/mock_computemanagement	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/identity	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer/mock_lb	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/vcn	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn	[no test files]
ok  	github.com/oracle/cluster-api-provider-oci/cloud/util	4.393s	coverage: 76.1% of statements
ok  	github.com/oracle/cluster-api-provider-oci/controllers	28.966s	coverage: 67.5% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1	27.348s	coverage: 18.7% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/api/v1beta2	1.138s	coverage: 9.5% of statements
ok  	github.com/oracle/cluster-api-provider-oci/exp/controllers	6.211s	coverage: 56.7% of statements
?   	github.com/oracle/cluster-api-provider-oci/feature	[no test files]
?   	github.com/oracle/cluster-api-provider-oci/version	[no test files]

@joekr joekr self-requested a review June 12, 2023 00:44
@joekr joekr added the enhancement New feature or request label Jun 12, 2023
shyamradhakrishnan and others added 14 commits June 12, 2023 20:21
@shyamradhakrishnan
Update metadata to next release (oracle#284)
3b368e9
@joekr
docs: update readme zoom link (oracle#278)
9fc3a28
@shyamradhakrishnan
Add docs for LBaaS support (oracle#286)
40c3141 
* Add docs for LBaaS support
@shyamradhakrishnan
Add node pool recycling (oracle#285)
e5676d6 
* Add OKE node pool recycling option
@shyamradhakrishnan
OKE addon support (oracle#287)
afd8fd0 
* Add support for OKE addons
@shyamradhakrishnan
Add doc for OKE addons and node pool cycling (oracle#290)
cc93896 
* Add doc for OKE addons and node pool cycling
@shyamradhakrishnan
Add Subnet Id and NSG ID to machine spec (oracle#291)
9f74b45 
* Add Subnet Id and NSG ID to machine spec
@shyamradhakrishnan
Remove references to local API reference docs (oracle#292)
2724252
@joekr
Update metadata to next release (oracle#296)
8cde3ee
@shyamradhakrishnan
Self managed nodes move oke from exp (oracle#298)
3cab342 
* OKE self managed nodes and move OKE out of experimental
@joekr
Update 1.26 (oracle#299)
03d3261 
* feat: Upgrade to Kubernetes 1.26
@shyamradhakrishnan
Increment metadata version (oracle#300)
43eaa99 
* Increment metadata version and minor changes in docs
@PreethamBojja
feat: added pagination for list calls
4d84afc
@PreethamBojja
Merge branch 'pagination-for-list-calls' of github.com:PreethamBojja/…
7ec6999 
…cluster-api-provider-oci into pagination-for-list-calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joekr joekr Awaiting requested review from joekr

At least 1 approving review is required to merge this pull request.

Assignees

@PreethamBojja PreethamBojja

Labels
enhancement New feature or request OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirm pagination on all list call
3 participants
@PreethamBojja @joekr @shyamradhakrishnan