Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GR-44559] Finish ThreadMXBean implementation for Native Image. #6101

Open
fniephaus opened this issue Mar 1, 2023 · 5 comments · May be fixed by #8430
Open

[GR-44559] Finish ThreadMXBean implementation for Native Image. #6101

fniephaus opened this issue Mar 1, 2023 · 5 comments · May be fixed by #8430
Labels
native-image
Projects
Native Image

Comments

@fniephaus
Copy link
Member

SubstrateThreadMXBean implements com.sun.management.ThreadMXBean for Native Image and is not fully implemented yet, for example:

graal/substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/management/SubstrateThreadMXBean.java

Lines 149 to 172 in 7268f71

@Override
public long[] getAllThreadIds() {
throw VMError.unsupportedFeature(MSG);
}
@Override
public ThreadInfo getThreadInfo(long id) {
throw VMError.unsupportedFeature(MSG);
}
@Override
public ThreadInfo[] getThreadInfo(long[] ids) {
throw VMError.unsupportedFeature(MSG);
}
@Override
public ThreadInfo getThreadInfo(long id, int maxDepth) {
throw VMError.unsupportedFeature(MSG);
}
@Override
public ThreadInfo[] getThreadInfo(long[] ids, int maxDepth) {
throw VMError.unsupportedFeature(MSG);
}

To improve JMX support (#4732), some of these methods throwing VMError.unsupportedFeature() will be switched to return reasonable, but empty default values (e.g., new ThreadInfo[0]). While this allows some JMX tools to work, some key functionality of ThreadMXBean is still missing and needs to be implemented.
@fniephaus fniephaus added this to To do in Native Image via automation Mar 1, 2023
@oeresundsgruppen
Copy link

Will this be in v23 ?

@fniephaus
Copy link
Member Author

Will this be in v23 ?

@oeresundsgruppen unfortunately no and we still haven't found anyone who has the time to work on this.

@smthelusive
Copy link

@fniephaus I would like to help! Can I pick it up?

@fniephaus
Copy link
Member Author

I would like to help! Can I pick it up?

Sure, feel free to take a look and let me know if you need any help. :)

@smthelusive smthelusive mentioned this issue Dec 4, 2023
Closed
@smthelusive
Copy link

Hi @fniephaus! I have created this PR, please take a look when you have time 🙂

@cstancu cstancu mentioned this issue Dec 6, 2023
Closed
@fniephaus fniephaus linked a pull request Feb 22, 2024 that will close this issue
Open
@fniephaus fniephaus moved this from To do to In progress in Native Image Feb 22, 2024
@smthelusive smthelusive removed their assignment Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
native-image
Projects
Native Image
  
In progress
Milestone
No milestone
3 participants
@fniephaus @oeresundsgruppen @smthelusive