Create a shared variable for db driver name. #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: galiacheng <haixia.cheng@microsoft.com> Changes to be committed: modified: weblogic-azure-aks/src/main/arm/scripts/buildWLSDockerImage.sh modified: weblogic-azure-aks/src/main/arm/scripts/common.sh modified: weblogic-azure-aks/src/main/arm/scripts/genImageModel.sh
zhengchang907
approved these changes
Jun 16, 2022
| export wdtDownloadURL="https://github.com/oracle/weblogic-deploy-tooling/releases/download/release-1.9.17/weblogic-deploy.zip" | ||
| export witDownloadURL="https://github.com/oracle/weblogic-image-tool/releases/download/release-1.9.16/imagetool.zip" | ||
| export wlsPostgresqlDriverUrl="https://jdbc.postgresql.org/download/postgresql-42.3.6.jar" | ||
| export wlsMSSQLDriverUrl="https://repo.maven.apache.org/maven2/com/microsoft/sqlserver/mssql-jdbc/10.2.1.jre8/mssql-jdbc-10.2.1.jre8.jar" |
There was a problem hiding this comment.
Maybe we can do something like:
export wlsMSSQLDriverUrl="https://repo.maven.apache.org/maven2/com/microsoft/sqlserver/mssql-jdbc/10.2.1.jre8/${constMSSQLDriverName}"
Not sure if it's better, because the download path /10.2.1.jre8/ seems not that friendly
Download link from GitHub also follows this pattern: https://github.com/microsoft/mssql-jdbc/releases/download/v10.2.1/mssql-jdbc-10.2.1.jre8.jar
There was a problem hiding this comment.
But I think it's reasonable to keep the default path, as this folder has all related files, it helps us with the location if someday we want to check other resources.
So I will keep the url link.
|
Test: |
This was referenced Jun 16, 2022
|
Close this pr, as #165 includes the changes and is approved by Ed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #160
Signed-off-by: galiacheng haixia.cheng@microsoft.com
Changes to be committed:
modified: weblogic-azure-aks/src/main/arm/scripts/buildWLSDockerImage.sh
modified: weblogic-azure-aks/src/main/arm/scripts/common.sh
modified: weblogic-azure-aks/src/main/arm/scripts/genImageModel.sh