Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes css/sass variable interpolation in tom-select.default.scss #684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a-maas
Copy link

@a-maas a-maas commented Jan 23, 2024

I believe this fixes #683, where I noticed that a SASS variable didn't get replaced in the package's dist file output. I haven't used SASS/SCSS in a while so I could be wrong. I'd be happy to address this differently if there's a different way to fix this.

@a-maas
Copy link
Author

a-maas commented Jan 23, 2024

I've confirmed that after applying this fix the css builds as expected.

image

Also, all tests still pass

Copy link

This pull request has not been active in 120 days and has been marked "stale". Remove stale label or comment or this will be closed in 15 days

@github-actions github-actions bot added the stale No activity label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale No activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: raw --ts-pr-min: $padding-x SASS variable present in css dist files
1 participant