Override for Variables and standard comment on PR #32915
Replies: 2 comments 1 reply
-
What you need to do is use the issues/comment API to create a pull-request comment: To quote the docs,
|
Beta Was this translation helpful? Give feedback.
-
🕒 Discussion Activity Reminder 🕒 This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions: 1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as 2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own. 3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution. Note: This dormant notification will only apply to Discussions with the Thank you for helping bring this Discussion to a resolution! 💬 |
Beta Was this translation helpful? Give feedback.
-
This comment is across both actions and API, for actions i have a solution but just to mention it here, the API that is the main issue, because there is no workaround for that at all
Actions
Actions: impossible to provide a runtime override for a variable used in CI script, this makes use of GitHub actions for infra based repositories useless, because if you are provisioning something and then the idea of infra as code is to be able to recreate that something with another name. k8s cluster or a namespace setup, which the cluster name or namespace name has to be able to provide via on demand input when you trigger the workflow, but this option is available via API? so what are you saying call GitHub API to provision infrastructure ? why don't i run it on my local? so i decide to use Gitlab for the infra pipeline, their pipelines provide value override at runtime.
API
do you know that it's nearly impossible to make a standard comment on a PR. you can only make 1 standard comment in the PR and it's considered as a review comment, so if you make another comment via the API it's rejected. Also the environment variables the reference to the pull request number can only be found in the pull request_created event type of run, from there on any push to the branch there is no way to look up the PR it belongs to even now i managed to use a local database in the hosted GitHub runner to maintain branch name pr number reference the fact that the API doesn't allow me to make a second comment on the PR make all that effort useless
i spend the whole evening even getting pr to branch name reference kept in a local database only to see
how do i make a usual comment in a PR, you can do it from the UI but why not from the API and what is up with the review comments and no mention of a regular comment. Seriously guys this ridiculous.
what is my use case i provision a instance of the system for each PR in a unique environment so to decide if its the first time so i create the environment and the second time just update the environment i sorted that out by looking at the EVENT type
there is no way to find pr number based on branch so i solved that using mongodb locally but then what i really want to finish the day with is
so i couldn't just post an updated comment to the PR comments
i thought i will use the comments API but that payload requires a path of a file, there is no way to make a global comment on a PR? what's preventing you from having such simple feature not available?
Beta Was this translation helpful? Give feedback.
All reactions