Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for esm #226

Open
Sceat opened this issue May 18, 2020 · 3 comments
Open

Support for esm #226

Sceat opened this issue May 18, 2020 · 3 comments

Comments

@Sceat
Copy link

Sceat commented May 18, 2020

import Task from 'folktale/concurrency/task/index.js'
const { task } = Task
// succeed
import { task } from 'folktale/concurrency/task/index.js'
// fails

Do you plan to support type modules ?
Thanks.

@robotlolita
Copy link
Member

It was planned for the next version, but between me moving to another country and not working with JavaScript anymore, finding time to maintain this library has been difficult :(

@opiation
Copy link

Hey @robotlolita, I can probably start working on a PR that rewrites all require()/module.exports as import/export and attempts to get CommonJS and ESM builds in the CI. I'll probably need some help after that though.

Any particular branch I should target for said PR?

@robotlolita
Copy link
Member

@opiation you can base it off the master branch, and PR towards the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants