Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Federation + base url #580

Open
terragady opened this issue Mar 5, 2024 · 3 comments
Open

Module Federation + base url #580

terragady opened this issue Mar 5, 2024 · 3 comments

Comments

@terragady
Copy link

terragady commented Mar 5, 2024

Hi, starting from Vite5 the module federation plugin was not working properly with the Vite.

We are using baseUrl, lets say /base/url and we have this setting in vite config:
base: "/base/url"
which is fine but the whole app does not work in dev mode (local server) and we figured out it needed setting server: { origin: "/base/url } and then it starts and module federation works properly but the problem starts with images now, they are not found because double base url is applied like http://localhost:8080/base/url/base/url/assets/images/image.png
so we have removed the origin and tried other fix and we had to use proxy for node_modules like this:
'/node_modules': 'http://localhost:8080/base/url/',

I think this is because module federation is using the origin to build the path but the origin destroy somehow pathing for assets (I found it is only the images, the js and the rest works just fine).

but my gut feeling says it is a wrong solution and hardcoding port and url here but it works fine with dev, build, federation and images. Anyone knows what is best solution here and what we are doing wrong/ or good? 🙂

@an501920078
Copy link

try add server.origin

@terragady
Copy link
Author

I am doing this but then the assets does not load as they have double base url

@an501920078
Copy link

Yes, I agree with you, and I also find that the new URL is problematic if you add server.origin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants