Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector nodes unnecessarily have heap allocated Vecs #28

Open
orium opened this issue Apr 10, 2018 · 1 comment
Open

Vector nodes unnecessarily have heap allocated Vecs #28

orium opened this issue Apr 10, 2018 · 1 comment

Comments

@orium
Copy link
Owner

orium commented Apr 10, 2018

This is bad because it involves more heap allocations and also more efford when Vecs need to expand.

To not lose the ability to configure the branching factor this is better done when rust-lang/rust#44580 is ready and stable. If we need this before const-generics stabilize then we can use the smallvec crate + some type aliases.

@michaelsproul
Copy link
Contributor

I'm going to have a crack at this, using const-generics for Vector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants