Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production build produces unwanted console logs. #356

Open
AlexA-1976 opened this issue Jun 29, 2020 · 7 comments
Open

Production build produces unwanted console logs. #356

AlexA-1976 opened this issue Jun 29, 2020 · 7 comments

Comments

@AlexA-1976
Copy link

AlexA-1976 commented Jun 29, 2020

Expected Behavior

No console logging should happen unless I explicitly put it there.

Actual Behavior

Every scroll-down this appears in the console log. On debug build, it doesn't happen.

(2)
 [{…}, {…}]
0: {contentHeight: undefined, scrolledFromTop: undefined, viewportHeight: undefined}
1: {contentHeight: undefined, scrolledFromTop: undefined, viewportHeight: undefined}
length: 2__
proto__: Array(0)

Steps To Reproduce / Demo (if applicable)

Using 'infiniteScroll' on a ul element. Scrolling behavior works.

Your Environment

"ngx-infinite-scroll": "^6.0.0",
"@angular/core": "6.1.10",
@orizens
Copy link
Owner

orizens commented Jun 29, 2020

hi @AlexA-1976 if you open a pr for v6 - i can publish it as next 6.

@AlexA-1976
Copy link
Author

@orizens I looked in the source just now and couldn't find any console.log() calls. Is it possible some lower level library is doing this?

@orizens
Copy link
Owner

orizens commented Jun 29, 2020

might be.
you would have to look into a commit from v6.

@orizens
Copy link
Owner

orizens commented Jun 29, 2020

@VikasKad
Copy link

VikasKad commented Dec 9, 2020

Is there any update on this issue? I am still getting this error.
My environment details are as follows:
"@angular/core": "^6.0.0",
"ngx-infinite-scroll": "^6.0.0",

@orizens
Copy link
Owner

orizens commented Dec 9, 2020

@VikasKad i dont see any pr for version 6.

@VikasKad
Copy link

VikasKad commented Mar 8, 2021

checkout this commit https://github.com/orizens/ngx-infinite-scroll/tree/fa01a048a7f98bcf42ac883051318f04f9e5baf0

I Checked in this commit, but I didn't find any console.log in it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants