Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Platform dependency #350

Open
jimohalloran opened this issue Apr 28, 2020 · 1 comment
Open

Incorrect Platform dependency #350

jimohalloran opened this issue Apr 28, 2020 · 1 comment

Comments

@jimohalloran
Copy link

Summary
The oro/crm package declares a dependency on oro/platform that is incorrect. Requires "4.1.*" actually "^4.1.1".

Steps to reproduce

Start with a blank "crm-application" at 4.1.0. Run composer install to install all dependencies and create the lock file. Add a dependency on oro/platform to the composer.json that forces platform 4.1.0 to be installed. Then run composer update to upgrade to upgrade to 4.1.2.

All dependencies will resolve correctly, and oro/crm 4.1.2 will be installed with oro/platform 4.1.0.

Actual Result
All attempts at accessing a page will result in the error:

Attempted to load class "BasicPermission" from namespace "Oro\Bundle\SecurityBundle\Acl".
Did you forget a "use" statement for another namespace?

Because BasicPermission is not present in Platfrom 4.1.0, and wasn't introduced until 4.1.1.

Expected Result
oro/crm 4.1.1 and later actually requires oro/platform 4.1.1 and later. Expected that the dependencies defined in composer.json should reflect this fact, and the composer update should fail with an error because dependencies could not be resolved.

Details about your environment

  • OroCRM version: 4.1.2 (upon upgrade from 4.1.0)

Not platform specific, other details (PHP version, etc) not applicable.

Additional information
Steps to reproduce describe a simple way to reproduce this problem, and obviously pinning the oro/platform version in your application's composer.json isn't wise. However, this is the simplest way to reproduce the problem. My own situation was a 3rd party package that both my application and oro/platform both depend upon which have conflicting version requirements. The conflict exists in 4.1.2, but not in 4.1.0, and this prevented composer upgrading oro/platform. Ideally I'd have liked to see this as a dependency resolution failure which prevented the upgrade, not as a totally broken application post upgrade that I needed to spend hours investigating.

@jimohalloran jimohalloran changed the title Incorred Platform dependency Incorrect Platform dependency Apr 28, 2020
@anyt anyt self-assigned this Apr 28, 2020
@anyt
Copy link
Contributor

anyt commented Apr 28, 2020

Thank you for the report!
Internal ticket id #BAP-17319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants