feat(table): enhance table with generics #919
Conversation
✅ Deploy Preview for oruga-documentation-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #919 +/- ##
============================================
- Coverage 56.71% 18.32% -38.39%
============================================
Files 30 292 +262
Lines 1511 7333 +5822
Branches 544 2113 +1569
============================================
+ Hits 857 1344 +487
- Misses 654 5037 +4383
- Partials 0 952 +952
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@mlmoravek I just checked out your PR and for your information on the table example page it seems to me that seachable is not working and dragging throws a js error. Also I looked at the code and I wonder why is it needed to compute an uuid, why not use the original data array row index as it seems to me that the original data array is never mutated ? |
|
@dauriata Thanks for the review! You are right, there is a problem with the search function. I will see if I can use the index instead of the uuid. At first I wrapped each row item completely and just emitted and worked with the wrapper item. But I changed it back. Maybe I can undo the uuid calculation too. |
Fixes #701
Fixes #924
Proposed Changes
processedemit which emits every time after the rows got processed