Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(programmatic): cleanup useProgrammatic composable #833

Merged
merged 16 commits into from
Jun 6, 2024

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Mar 2, 2024

Part of #829
Fixes #828

Proposed Changes

  • cleanup useProgrammatic composable
  • update useClickOutside and useEventListener composables
  • remove unnecessary onCancel prop from loading; modal; notification; sidebar

@mlmoravek mlmoravek added breaking Breaking changes refactoring This involves some refactoring of existing code. labels Mar 2, 2024
Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit f1caeca
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/6661bb86a535a80008a31aae
😎 Deploy Preview https://deploy-preview-833--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 120 lines in your changes missing coverage. Please review.

Project coverage is 18.23%. Comparing base (484cfe8) to head (f1caeca).
Report is 77 commits behind head on develop.

Files Patch % Lines
packages/oruga/src/components/modal/Modal.vue 0.00% 20 Missing and 12 partials ⚠️
packages/oruga/src/components/sidebar/Sidebar.vue 0.00% 20 Missing and 11 partials ⚠️
packages/oruga/src/composables/useProgrammatic.ts 0.00% 17 Missing and 12 partials ⚠️
packages/oruga/src/components/loading/Loading.vue 0.00% 8 Missing and 4 partials ⚠️
...src/components/notification/NotificationNotice.vue 0.00% 5 Missing and 3 partials ⚠️
packages/oruga/src/composables/useEventListener.ts 76.19% 4 Missing and 1 partial ⚠️
...ackages/oruga/src/components/dropdown/Dropdown.vue 90.90% 1 Missing ⚠️
...c/components/loading/examples/programmatically.vue 0.00% 1 Missing ⚠️
packages/oruga/src/composables/useClickOutside.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #833       +/-   ##
============================================
- Coverage    56.71%   18.23%   -38.49%     
============================================
  Files           30      292      +262     
  Lines         1511     7370     +5859     
  Branches       544     2149     +1605     
============================================
+ Hits           857     1344      +487     
- Misses         654     5066     +4412     
- Partials         0      960      +960     
Flag Coverage Δ
oruga-next 18.23% <20.00%> (-38.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek changed the title refactor(programmatic): cleanup useProgrammatic composable refactor(programmatic): cleanup useProgrammatic composable Mar 2, 2024
@mlmoravek mlmoravek merged commit c509666 into oruga-ui:develop Jun 6, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript error : Type 'HTMLElement | null' is not assignable to type 'string | HTMLElement | undefined'.
1 participant