Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable datadog tracer #3431

Merged
merged 4 commits into from Feb 6, 2023
Merged

fix: enable datadog tracer #3431

merged 4 commits into from Feb 6, 2023

Conversation

sawadashota
Copy link
Contributor

Load OpenTelemetry configuration to set up datadog tracer.

Related issue(s)

none

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Signed-off-by: sawadashota <shota@sslife.tech>
@@ -6,7 +6,7 @@ WORKDIR /go/src/github.com/ory/hydra
RUN mkdir -p ./internal/httpclient

COPY go.mod go.sum ./
COPY internal/httpclient/go.* ./internal/httpclient
COPY internal/httpclient/go.* ./internal/httpclient/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without a trailing slash, it will fail.

Step 6/21 : COPY internal/httpclient/go.* ./internal/httpclient
When using COPY with more than one source file, the destination must be a directory and end with a /
make: *** [docker] Error 1

@sawadashota sawadashota changed the title fix: Enable datadog tracer fix: enable datadog tracer Feb 5, 2023
@aeneasr aeneasr requested a review from alnr February 5, 2023 14:30
@aeneasr
Copy link
Member

aeneasr commented Feb 5, 2023

Seems like tests are failing, can you PTAL? :)

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #3431 (ce2f444) into master (5585539) will increase coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3431      +/-   ##
==========================================
+ Coverage   76.47%   76.74%   +0.26%     
==========================================
  Files         123      123              
  Lines       10535     9022    -1513     
==========================================
- Hits         8057     6924    -1133     
+ Misses       1990     1657     -333     
+ Partials      488      441      -47     
Impacted Files Coverage Δ
driver/config/provider.go 82.55% <0.00%> (-5.70%) ⬇️
consent/handler.go 66.01% <0.00%> (-4.99%) ⬇️
persistence/sql/persister_consent.go 87.41% <0.00%> (-2.34%) ⬇️
driver/registry_base.go 85.93% <0.00%> (-1.76%) ⬇️
x/clean_sql.go 91.11% <0.00%> (-1.62%) ⬇️
consent/manager.go 100.00% <0.00%> (ø)
consent/strategy_default.go 69.59% <0.00%> (+0.59%) ⬆️
fositex/config.go 86.11% <0.00%> (+2.64%) ⬆️
oauth2/handler.go 66.50% <0.00%> (+2.82%) ⬆️
persistence/sql/persister_oauth2.go 82.12% <0.00%> (+5.86%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sawadashota
Copy link
Contributor Author

@aeneasr I'm sorry, but I've fixed it!

Copy link
Contributor

@alnr alnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sawadashota

@aeneasr aeneasr merged commit 3ea014f into ory:master Feb 6, 2023
@sawadashota sawadashota deleted the config_otel branch February 6, 2023 13:38
harnash pushed a commit to Wikia/ory-hydra that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants