Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: oauth2-client get client: fix example --json option #3497

Merged
merged 1 commit into from Apr 29, 2023

Conversation

kangaechu
Copy link
Contributor

@kangaechu kangaechu commented Apr 21, 2023

The --json option does not exist in the current version of hydra. The --format json option had been added in place of the --json option. However, the --json option was left in the example. So, I fixed it.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

The --json option does not exist in the current version of hydra. The --format json option had been added in place of the --json option.
However, the --json option was left in the example.
So, I fixed it.
@kangaechu kangaechu requested a review from aeneasr as a code owner April 21, 2023 12:40
@CLAassistant
Copy link

CLAassistant commented Apr 21, 2023

CLA assistant check
All committers have signed the CLA.

@kangaechu kangaechu changed the title oauth2-client get client: fix example --json option fix: oauth2-client get client: fix example --json option Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #3497 (3decda3) into master (cf20054) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 3decda3 differs from pull request most recent head 3236557. Consider uploading reports for the commit 3236557 to get more accurate results

@@           Coverage Diff           @@
##           master    #3497   +/-   ##
=======================================
  Coverage   76.87%   76.87%           
=======================================
  Files         124      124           
  Lines        9175     9175           
=======================================
  Hits         7053     7053           
  Misses       1673     1673           
  Partials      449      449           
Impacted Files Coverage Δ
cmd/cmd_get_client.go 83.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! 🎉 Your contribution makes Ory better :)

@aeneasr aeneasr merged commit b71a36b into ory:master Apr 29, 2023
30 of 37 checks passed
@kangaechu kangaechu deleted the fix-get-client-example branch May 2, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants