Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return proper error when the grant request cannot be parsed #3558

Merged
merged 2 commits into from Jun 29, 2023

Conversation

hperl
Copy link
Contributor

@hperl hperl commented Jun 28, 2023

For some requests to /admin/trust/grants/jwt-bearer/issuers, Hydra would issue generic 500 error messages if decoding the request failed. This left users with no way to fix the request. Errors during decoding are now wrapped in a proper 400 Bad Request status and describe the error.

Fixes ory/network#310

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl requested a review from aeneasr as a code owner June 28, 2023 10:59
@hperl hperl requested review from piotrmsc and zepatrik June 28, 2023 10:59
@hperl hperl self-assigned this Jun 28, 2023
@hperl hperl merged commit 26f2d34 into master Jun 29, 2023
29 checks passed
@hperl hperl deleted the hperl/fix-post-jwt-bearer-issuers branch June 29, 2023 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get 500 'The error is unrecognizable' when trying to establish a trust relationship for a JWT issuer
3 participants