Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct id token type in token exchange response #3625

Merged
merged 1 commit into from Sep 5, 2023

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Sep 5, 2023

Closes ory/client-go#2

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@aeneasr aeneasr marked this pull request as ready for review September 5, 2023 12:36
@aeneasr aeneasr requested a review from hperl as a code owner September 5, 2023 12:36
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #3625 (6975e8a) into master (af0d477) will increase coverage by 0.01%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

❗ Current head 6975e8a differs from pull request most recent head 615725a. Consider uploading reports for the commit 615725a to get more accurate results

@@            Coverage Diff             @@
##           master    #3625      +/-   ##
==========================================
+ Coverage   76.16%   76.18%   +0.01%     
==========================================
  Files         133      133              
  Lines       10043    10043              
==========================================
+ Hits         7649     7651       +2     
+ Misses       1870     1868       -2     
  Partials      524      524              
Files Changed Coverage Δ
oauth2/handler.go 67.94% <ø> (ø)

... and 1 file with indirect coverage changes

@aeneasr aeneasr merged commit d1f9ba8 into master Sep 5, 2023
31 checks passed
@aeneasr aeneasr deleted the fix-client-go-2 branch September 5, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuth2TokenExchange struct IdToken not int64
1 participant