Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skip_logout_consent option to clients #3705

Merged
merged 3 commits into from Jan 30, 2024
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Jan 30, 2024

Adds a special field which disables the logout consent screen when performing OIDC logout.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Adds a special field which disables the logout consent screen when performing OIDC logout.
@aeneasr aeneasr requested a review from hperl as a code owner January 30, 2024 08:34
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (39ee5e1) 75.98% compared to head (a2ee989) 76.02%.
Report is 9 commits behind head on master.

Files Patch % Lines
cmd/cmd_import_jwk.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3705      +/-   ##
==========================================
+ Coverage   75.98%   76.02%   +0.03%     
==========================================
  Files         134      134              
  Lines       10065    10136      +71     
==========================================
+ Hits         7648     7706      +58     
- Misses       1904     1912       +8     
- Partials      513      518       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aeneasr aeneasr merged commit 2a653e6 into master Jan 30, 2024
31 checks passed
@aeneasr aeneasr deleted the remove-logout-flow branch January 30, 2024 15:19
@@ -0,0 +1 @@
ALTER TABLE hydra_client DROP COLUMN skip_consent;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aeneasr added a commit that referenced this pull request Jan 30, 2024
@aeneasr aeneasr mentioned this pull request Jan 30, 2024
7 tasks
aeneasr added a commit that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants