Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return empty slice if requested_scope or audience is null #3711

Merged
merged 2 commits into from Feb 12, 2024

Conversation

jonas-jonas
Copy link
Contributor

Related issue(s)

Fixes #3655

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bfc05d0) 76.06% compared to head (254547b) 76.22%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3711      +/-   ##
==========================================
+ Coverage   76.06%   76.22%   +0.15%     
==========================================
  Files         134      134              
  Lines       10142    10210      +68     
==========================================
+ Hits         7715     7783      +68     
  Misses       1910     1910              
  Partials      517      517              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aeneasr
aeneasr previously approved these changes Feb 5, 2024
@@ -364,6 +364,14 @@ func (h *Handler) getOAuth2LoginRequest(w http.ResponseWriter, r *http.Request,
return
}

if request.RequestedScope == nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do this in consent as well?

Or just override the MarshalJSON method?

@aeneasr aeneasr merged commit 65165e7 into ory:master Feb 12, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loginRequest.requested_access_token_audience is setting to null instead of []
2 participants