Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

[RFC 216/ PushStream] Inconsistency between JavaDoc/Spec Section 706.7.14.6 and the reference implementation #39

Open
bjhargrave opened this issue Dec 10, 2018 · 1 comment
Assignees
Labels
publiccomment Public comment

Comments

@bjhargrave
Copy link
Member

Original bug ID: BZ#228
From: Clément Delgrange <cl.delgrange@protonmail.com>
Reported version: R7

@bjhargrave
Copy link
Member Author

Comment author: Clément Delgrange <cl.delgrange@protonmail.com>

Overview:

The JavaDoc of the SimplePushEventSource.publish method (section 706.7.14.6) indicates that the method throws an IllegalStateException if the source is closed. However, the reference implementation org.osgi:org.osgi.util.pushstream:1.0.0 return immediately and does not throw the exception when the source is closed.

Actual Results:

The user cannot decide which of the specification or the implementation is right. This may lead to bugs in the client code.

Expected Results:

Either the specification should remove the "throws" clause or the implementation should throw the exception.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
publiccomment Public comment
Projects
None yet
Development

No branches or pull requests

2 participants