Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pom.xml has no dependencies anymore? #144

Closed
reconman opened this issue Sep 14, 2020 · 3 comments
Closed

pom.xml has no dependencies anymore? #144

reconman opened this issue Sep 14, 2020 · 3 comments

Comments

@reconman
Copy link

In version 1.8.3, the pom.xml still had slf4j-api, and some kotlin libraries as dependencies, but now the pom.xml has 0 dependencies: https://repo1.maven.org/maven2/io/github/microutils/kotlin-logging/1.11.3/kotlin-logging-1.11.3.pom

What happened to cause this? Can you add the slf4j-api dependency again?
@oshai
Copy link
Owner

oshai commented Sep 15, 2020

Thanks for reporting the issue! I will check it.
There was a change in the packaging since 1.8.3 and this is probably related. It wasn't intended.

@oshai
Copy link
Owner

oshai commented Sep 15, 2020

It is related to the change done in 1.11.1 by #137 . The last version with correct pom was 1.11.0.

Since we have one more issue with 1.4, I think I will revert to Kotlin 1.3 in a branch and publish it.

@oshai oshai mentioned this issue Sep 15, 2020
Closed
oshai added a commit that referenced this issue Sep 15, 2020
@oshai
issue #144 - revert back to kotlin 1.3
34b0596 
* Add release from branch `kotlin-1.3`
* Comment out native targets instead of reverting them.
oshai added a commit that referenced this issue Sep 15, 2020
@oshai
issue #144 - revert module configuration
2b85b04
@altavir altavir mentioned this issue Sep 15, 2020
Merged
@oshai
Copy link
Owner

oshai commented Sep 15, 2020

It turns out this was caused by a bug in gradle related gradle metadata feature. After Upgrading gradle to 6.6.1 this was solved.
Fixed in kotlin-logging 1.11.5.

@oshai oshai closed this as completed Sep 15, 2020
reconman added a commit to Fate-Grand-Automata/FGA that referenced this issue Sep 15, 2020
@reconman
Update kotlin-logging to 1.11.5
0b8bdf7 
The slf4j-api dependency was missing due to oshai/kotlin-logging#144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oshai @reconman