Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache Log4j Security Vulnerabilities #206

Closed
apb-kawaguchi-kazuki opened this issue Dec 10, 2021 · 3 comments
Closed

Apache Log4j Security Vulnerabilities #206

apb-kawaguchi-kazuki opened this issue Dec 10, 2021 · 3 comments

Comments

@apb-kawaguchi-kazuki
Copy link

apb-kawaguchi-kazuki commented Dec 10, 2021

i want to know about necessity of update this library version update.

found log4j version v2.14.1 for this library.
this version is under vulnerabilities.
but it only use in jvmTest.
https://github.com/MicroUtils/kotlin-logging/blob/master/build.gradle.kts

I'm sorry, but i cant judge necessity of this Vulnerability affects for service.
sorry for my poor English.

▼official
https://logging.apache.org/log4j/2.x/security.html

@github-actions
Copy link

Thank you for reporting an issue. See the wiki for documentation and slack for questions.

@oshai
Copy link
Owner

oshai commented Dec 10, 2021

fixed in #207 - and anyway since this is just used in tests, there isn't a real risk for users.

@oshai
Copy link
Owner

oshai commented Dec 13, 2021

Some more background on the issue, copied from #207.

kotlin-logging is a facade (similar to slf4j) means it only wraps the implementation you choose as a logging framework.
Popular implementations are logback and log4j.
On the tests of kotlin-logging we needed an actual implementation to use. We could write our own mocks but it makes more sense to take an actual impl for that to reflect how users use the lib. So kotlin-logging depends on log4j for testing only.
Example of such tests can be seen here.
You can see the dependency here:
image

It means that this dependency does not pass transitively to users of kotlin-logging, and therfore users don't need to upgrade kotlin-logging itself. You can also see that in the pom that is generated for kotlin-logging.
For people to feel more safe and for our own safety (when running tests) we upgraded kotlin-logging dependency on log4j.
So it's not really needed, but I will not stop you from upgrading.

Hope that clears things a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants