packet/bgp,mup: fix decode Interwork Segment Discovery route

osrg · Jan 28, 2023 · c61ef62 · c61ef62
1 parent 033cfdb
commit c61ef62
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/pkg/packet/bgp/mup.go b/pkg/packet/bgp/mup.go
@@ -292,10 +292,8 @@ func (r *MUPInterworkSegmentDiscoveryRoute) DecodeFromBytes(data []byte, afi uin
 	if bits > addrLen*8 {
 		return NewMessageError(BGP_ERROR_UPDATE_MESSAGE_ERROR, BGP_ERROR_SUB_MALFORMED_ATTRIBUTE_LIST, nil, "prefix length is too long")
 	}
-	b := data[p:]
-	if addrLen > len(data[p:]) {
-		b = append(b, make([]byte, addrLen-len(data[p:]))...)
-	}
+	b := make([]byte, addrLen)
+	copy(b[0:byteLen], data[p:p+byteLen])
 	addr, ok := netip.AddrFromSlice(b)
 	if !ok {
 		return NewMessageError(BGP_ERROR_UPDATE_MESSAGE_ERROR, BGP_ERROR_SUB_MALFORMED_ATTRIBUTE_LIST, nil, fmt.Sprintf("Invalid Prefix: %x", data[p:]))