Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release workflow to run on a manual trigger #15

Closed
laurentsimon opened this issue Dec 6, 2021 · 3 comments
Closed

Fix release workflow to run on a manual trigger #15

laurentsimon opened this issue Dec 6, 2021 · 3 comments
Milestone

Comments

@laurentsimon
Copy link
Contributor

laurentsimon commented Dec 6, 2021

https://github.com/ossf/scorecard-action/blob/main/action.yaml#L48 we need to pin our docker.
However, there's a problem because we currently generate the docker file upon new release generation thru this workflow https://github.com/ossf/scorecard-action/blob/main/.github/workflows/docker-sign.yml

This is a chicken-and-egg problem: in order to generate the release, we need the right hash to pin the action's docker image. But to generate it, we need a release. We may need to split the problem into 2 stages:

  1. Generation of docker image
  1. Generate the release

@naveensrinivasan @azeemshaikh38 other ideas?

@laurentsimon laurentsimon added this to the v1 milestone Dec 29, 2021
@laurentsimon
Copy link
Contributor Author

this is done now. Closing

@laurentsimon
Copy link
Contributor Author

laurentsimon commented Dec 30, 2021

@naveensrinivasan I now remember why this needs some update. We need to generate the action container image based on a manual GitHub trigger. It does not work on a push trigger.

Currently we generate the image at release time. However, we need the image hash to edit https://github.com/ossf/scorecard-action/blob/main/action.yaml#L45 prior to releasing. I've listed the steps necessary to release the action in #33

Does this make sense?

@laurentsimon laurentsimon changed the title Pin docker image in action.yml Fix release workflow to run on a manual trigger Dec 30, 2021
@laurentsimon
Copy link
Contributor Author

Fixed by #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant