From ada5a0818d0f067a99dcfe3e134acac218479536 Mon Sep 17 00:00:00 2001 From: Yosuke Ota Date: Sat, 23 Mar 2024 18:18:39 +0900 Subject: [PATCH] fix: `useSchemastoreCatalog` is enabled by default according to docs. (#305) * fix: `useSchemastoreCatalog` is enabled by default according to docs. * Create sixty-mice-arrive.md * add test --- .changeset/sixty-mice-arrive.md | 5 +++++ src/rules/no-invalid.ts | 3 ++- tests/src/rules/no-invalid.ts | 9 +++++++++ 3 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 .changeset/sixty-mice-arrive.md diff --git a/.changeset/sixty-mice-arrive.md b/.changeset/sixty-mice-arrive.md new file mode 100644 index 00000000..6939e8f4 --- /dev/null +++ b/.changeset/sixty-mice-arrive.md @@ -0,0 +1,5 @@ +--- +"eslint-plugin-json-schema-validator": major +--- + +fix: `useSchemastoreCatalog` is enabled by default according to docs. diff --git a/src/rules/no-invalid.ts b/src/rules/no-invalid.ts index bd4264e3..b08c478a 100644 --- a/src/rules/no-invalid.ts +++ b/src/rules/no-invalid.ts @@ -403,7 +403,8 @@ export default createRule("no-invalid", { relativeFilename: string, ): Validator[] | null { const option = context.options[0] || {}; - if (!option.useSchemastoreCatalog) { + const useSchemastoreCatalog = option.useSchemastoreCatalog !== false; + if (!useSchemastoreCatalog) { return null; } diff --git a/tests/src/rules/no-invalid.ts b/tests/src/rules/no-invalid.ts index 43130cbc..3fde4e65 100644 --- a/tests/src/rules/no-invalid.ts +++ b/tests/src/rules/no-invalid.ts @@ -42,6 +42,15 @@ tester.run( }, ], invalid: [ + { + filename: ".eslintrc.json", + code: '{ "extends": [ 42 ] }', + errors: [ + '"extends" must be string.', + '"extends" must match exactly one schema in oneOf.', + '"extends[0]" must be string.', + ], + }, { filename: ".eslintrc.json", code: '{ "extends": [ 42 ] }',