Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ota-meshi/eslint-plugin-node-dependencies
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.10.0
Choose a base ref
...
head repository: ota-meshi/eslint-plugin-node-dependencies
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.11.0
Choose a head ref
  • 18 commits
  • 11 files changed
  • 4 contributors

Commits on Oct 28, 2022

  1. Update dependency eslint-plugin-node-dependencies to ^0.10.0 (#78)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Oct 28, 2022

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    9e54e5d View commit details

Commits on Mar 18, 2023

  1. chore(deps): update coverallsapp/github-action action to v1.2.4 (#79)

    * chore(deps): update coverallsapp/github-action action to v1.2.4
    
    * format
    
    ---------
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    Co-authored-by: ota-meshi <otameshiyo23@gmail.com>
    renovate[bot] and ota-meshi authored Mar 18, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    397afa2 View commit details
  2. Copy the full SHA
    7495628 View commit details
  3. chore(deps): update coverallsapp/github-action action to v2 (#82)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Mar 18, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    c5e2332 View commit details
  4. chore(deps): update actions/configure-pages action to v3 (#81)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Mar 18, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    7ce1342 View commit details
  5. Copy the full SHA
    4c9b16f View commit details
  6. Copy the full SHA
    710d03f View commit details
  7. chore(deps): update dependency typescript to v5 (#85)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Mar 18, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    85de2e0 View commit details

Commits on Mar 19, 2023

  1. chore(deps): update actions/deploy-pages action to v2 (#86)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Mar 19, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    1ecb86d View commit details

Commits on Apr 1, 2023

  1. chore(deps): update dependency stylelint-config-standard to v32 (#87)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 1, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    f91ca8d View commit details
  2. chore: fix doc site script

    ota-meshi committed Apr 1, 2023
    Copy the full SHA
    781f4e2 View commit details
  3. chore: format

    ota-meshi committed Apr 1, 2023
    Copy the full SHA
    7d41012 View commit details

Commits on Apr 10, 2023

  1. chore(deps): update coverallsapp/github-action action to v2.1.0 (#88)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 10, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    9a600c1 View commit details

Commits on Apr 16, 2023

  1. Copy the full SHA
    087bb4c View commit details

Commits on Apr 18, 2023

  1. Copy the full SHA
    b179ce3 View commit details

Commits on Apr 20, 2023

  1. Copy the full SHA
    ee2d16c View commit details

Commits on May 9, 2023

  1. feat: export meta object (#92)

    * feat: export meta object
    
    * Create purple-needles-wave.md
    ota-meshi authored May 9, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    06a3daa View commit details
  2. chore: release eslint-plugin-node-dependencies (#93)

    Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
    github-actions[bot] and github-actions[bot] authored May 9, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    24f8864 View commit details
Showing with 47 additions and 10 deletions.
  1. +2 −2 .github/workflows/GHPages.yml
  2. +1 −1 .github/workflows/NodeCI.yml
  3. +6 −0 CHANGELOG.md
  4. +4 −0 docs/.vuepress/config.js
  5. +7 −0 docs/.vuepress/shim/eslint-visitor-keys/index.js
  6. +2 −0 lib/index.ts
  7. +3 −0 lib/meta.ts
  8. +1 −1 lib/rules/absolute-version.ts
  9. +6 −6 package.json
  10. +14 −0 tests/lib/meta.ts
  11. +1 −0 tsconfig.json
4 changes: 2 additions & 2 deletions .github/workflows/GHPages.yml
Original file line number Diff line number Diff line change
@@ -35,11 +35,11 @@ jobs:
export NODE_OPTIONS=--openssl-legacy-provider
npm run docs:build
- name: Setup Pages
uses: actions/configure-pages@v2
uses: actions/configure-pages@v3
- name: Upload artifact
uses: actions/upload-pages-artifact@v1
with:
path: ./docs/.vuepress/dist
- name: Deploy to GitHub Pages
id: deployment
uses: actions/deploy-pages@v1
uses: actions/deploy-pages@v2
2 changes: 1 addition & 1 deletion .github/workflows/NodeCI.yml
Original file line number Diff line number Diff line change
@@ -59,7 +59,7 @@ jobs:
- name: Test
run: npm run test:nyc
- name: Coveralls GitHub Action
uses: coverallsapp/github-action@1.1.3
uses: coverallsapp/github-action@v2.1.2
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
update:
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# eslint-plugin-node-dependencies

## 0.11.0

### Minor Changes

- [#92](https://github.com/ota-meshi/eslint-plugin-node-dependencies/pull/92) [`06a3daa`](https://github.com/ota-meshi/eslint-plugin-node-dependencies/commit/06a3daa15dd7f04f22eb79c86cd73c4969a6c8ae) Thanks [@ota-meshi](https://github.com/ota-meshi)! - feat: export meta object

## 0.10.0

### Minor Changes
4 changes: 4 additions & 0 deletions docs/.vuepress/config.js
Original file line number Diff line number Diff line change
@@ -37,6 +37,10 @@ module.exports = {
alias: {
module: require.resolve("./shim/module"),
eslint$: path.resolve(__dirname, "./shim/eslint"),
"eslint-visitor-keys$": path.resolve(
__dirname,
"./shim/eslint-visitor-keys"
),
esquery: path.resolve(
__dirname,
"../../node_modules/esquery/dist/esquery.min.js"
7 changes: 7 additions & 0 deletions docs/.vuepress/shim/eslint-visitor-keys/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// eslint-disable-next-line eslint-comments/disable-enable-pair -- DEMO
/* eslint-disable node/no-unsupported-features/es-syntax -- DEMO */
import * as all from "../../../../node_modules/eslint-visitor-keys/lib/index";

const evk = all.default || all;
export const { KEYS, getKeys, unionWith } = evk;
export default evk;
2 changes: 2 additions & 0 deletions lib/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import type { RuleModule } from "./types";
import { rules as ruleList } from "./utils/rules";
import recommended from "./configs/recommended";
import * as meta from "./meta";

const configs = {
recommended,
@@ -12,6 +13,7 @@ const rules = ruleList.reduce((obj, r) => {
}, {} as { [key: string]: RuleModule });

export = {
meta,
configs,
rules,
};
3 changes: 3 additions & 0 deletions lib/meta.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
// note - cannot migrate this to an import statement because it will make TSC copy the package.json to the dist folder
// eslint-disable-next-line @typescript-eslint/no-require-imports, @typescript-eslint/no-var-requires -- Get meta data
export const { name, version } = require("../package.json");
2 changes: 1 addition & 1 deletion lib/rules/absolute-version.ts
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ const SCHEMA_FOR_DEPS_PROPERTIES = {
optionalDependencies: { enum: PREFERS },
devDependencies: { enum: PREFERS },
};
type Prefer = typeof PREFERS[number];
type Prefer = (typeof PREFERS)[number];
type FullOption = {
dependencies: Prefer;
peerDependencies: Prefer;
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-plugin-node-dependencies",
"version": "0.10.0",
"version": "0.11.0",
"description": "ESLint plugin to check Node.js dependencies.",
"engines": {
"node": ">=14.17.0"
@@ -77,7 +77,7 @@
"eslint-plugin-json-schema-validator": "^4.0.0",
"eslint-plugin-jsonc": "^2.0.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-node-dependencies": "^0.9.0",
"eslint-plugin-node-dependencies": "^0.10.0",
"eslint-plugin-prettier": "^4.0.0",
"eslint-plugin-regexp": "^1.0.0",
"eslint-plugin-vue": "^9.0.0",
@@ -88,12 +88,12 @@
"nyc": "^15.1.0",
"prettier": "^2.0.5",
"raw-loader": "^4.0.1",
"stylelint": "^14.0.0",
"stylelint": "^15.0.0",
"stylelint-config-recommended-vue": "^1.0.0",
"stylelint-config-standard": "^29.0.0",
"stylelint-stylus": "^0.17.0",
"stylelint-config-standard": "^33.0.0",
"stylelint-stylus": "^0.18.0",
"ts-node": "^10.0.0",
"typescript": "^4.0.0",
"typescript": "^5.0.0",
"vue-eslint-editor": "^1.1.0",
"vue-eslint-parser": "^9.0.0",
"vuepress": "^1.5.2"
14 changes: 14 additions & 0 deletions tests/lib/meta.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
import assert from "assert";
import plugin from "../../lib";
import { version } from "../../package.json";
const expectedMeta = {
name: "eslint-plugin-node-dependencies",
version,
};

describe("Test for meta object", () => {
it("A plugin should have a meta object.", () => {
assert.strictEqual(plugin.meta.name, expectedMeta.name);
assert.strictEqual(typeof plugin.meta.version, "string");
});
});
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -18,6 +18,7 @@
"*": ["typings/*"]
},
"esModuleInterop": true,
"resolveJsonModule": true,

"skipLibCheck": true
},