Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ota-meshi/eslint-plugin-node-dependencies
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.5.1
Choose a base ref
...
head repository: ota-meshi/eslint-plugin-node-dependencies
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.6.0
Choose a head ref
  • 6 commits
  • 4 files changed
  • 3 contributors

Commits on Oct 26, 2021

  1. Update dependency @types/node to v16 (#16) 

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    @renovate @renovate-bot
    renovate[bot] and renovate-bot authored Oct 26, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    5b1ea4d View commit details

  2. Update dependency stylelint-plugin-stylus to ^0.13.0 (#15) 

    * Update dependency stylelint-plugin-stylus to ^0.13.0

* update

* update

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
    @renovate @renovate-bot @ota-meshi
    3 people authored Oct 26, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    a3c5c9f View commit details

Commits on Oct 29, 2021

  1. Update dependency eslint-plugin-vue to v8 (#17) 

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    @renovate @renovate-bot
    renovate[bot] and renovate-bot authored Oct 29, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    6e3fc99 View commit details

Commits on Nov 5, 2021

  1. Update dependency eslint-plugin-jsonc to v2 (#18) 

    Co-authored-by: Renovate Bot <bot@renovateapp.com>
    @renovate @renovate-bot
    renovate[bot] and renovate-bot authored Nov 5, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    80235b6 View commit details

  2. Update dependency jsonc-eslint-parser to v2 (#19) 

    * Update dependency jsonc-eslint-parser to v2

* update

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: yosuke ota <otameshiyo23@gmail.com>
    @renovate @renovate-bot @ota-meshi
    3 people authored Nov 5, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    9b2795a View commit details

  3. 0.6.0

    @ota-meshi
    ota-meshi committed Nov 5, 2021
    Copy the full SHA
    fdfa046 View commit details
Showing with 13 additions and 11 deletions.
  1. +0 −3 .vscode/settings.json
  2. +2 −1 docs/.vuepress/components/stylelint.config.js
  3. +4 −1 lib/utils/ast-utils.ts
  4. +7 −6 package.json
3 changes: 0 additions & 3 deletions .vscode/settings.json
View file
Original file line number Diff line number Diff line change
@@ -18,7 +18,6 @@
"source.fixAll.eslint": true,
"source.fixAll.stylelint": true
},
"stylelint.customSyntax": "stylelint-plugin-stylus/custom-syntax",
"stylelint.validate": [
"css",
"html",
@@ -27,8 +26,6 @@
"sass",
"scss",
"vue",
"vue-html",
"vue-postcss",
"stylus"
]
}
3 changes: 2 additions & 1 deletion docs/.vuepress/components/stylelint.config.js
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
module.exports = {
extends: ["stylelint-config-standard"],
extends: ["stylelint-config-standard", "stylelint-config-recommended-vue"],
rules: {
"no-descending-specificity": null,
indentation: null,
"selector-class-pattern": null,
},
}
5 changes: 4 additions & 1 deletion lib/utils/ast-utils.ts
View file
Original file line number Diff line number Diff line change
@@ -17,7 +17,10 @@ export function getKeyFromJSONProperty(
*/
export function getKey(node: AST.JSONExpression): string | number | null {
let parent = node.parent!
while (parent.type === "JSONUnaryExpression") {
while (
parent.type === "JSONUnaryExpression" ||
parent.type === "JSONBinaryExpression"
) {
parent = parent.parent
}
if (parent.type === "JSONExpressionStatement") {
13 changes: 7 additions & 6 deletions package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-plugin-node-dependencies",
"version": "0.5.1",
"version": "0.6.0",
"description": "ESLint plugin to check Node.js dependencies.",
"engines": {
"node": "^12 || >=14"
@@ -57,7 +57,7 @@
"@types/eslint-visitor-keys": "^1.0.0",
"@types/estree": "^0.0.50",
"@types/mocha": "^9.0.0",
"@types/node": "^14.14.39",
"@types/node": "^16.0.0",
"@types/npm-package-arg": "^6.1.1",
"@types/semver": "^7.3.8",
"@typescript-eslint/eslint-plugin": "^5.0.0",
@@ -69,12 +69,12 @@
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-eslint-plugin": "^4.0.0",
"eslint-plugin-json-schema-validator": "^1.0.9",
"eslint-plugin-jsonc": "^1.0.0",
"eslint-plugin-jsonc": "^2.0.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-node-dependencies": "^0.5.0",
"eslint-plugin-prettier": "^4.0.0",
"eslint-plugin-regexp": "^1.0.0",
"eslint-plugin-vue": "^7.5.0",
"eslint-plugin-vue": "^8.0.0",
"eslint-plugin-yml": "^0.10.0",
"eslint4b": "^7.3.1",
"mocha": "^9.0.0",
@@ -83,16 +83,17 @@
"prettier": "^2.0.5",
"raw-loader": "^4.0.1",
"stylelint": "^14.0.0",
"stylelint-config-recommended-vue": "^1.0.0",
"stylelint-config-standard": "^23.0.0",
"stylelint-plugin-stylus": "^0.11.0",
"stylelint-plugin-stylus": "^0.13.0",
"ts-node": "^10.0.0",
"typescript": "^4.0.0",
"vue-eslint-editor": "^1.1.0",
"vue-eslint-parser": "^8.0.0",
"vuepress": "^1.5.2"
},
"dependencies": {
"jsonc-eslint-parser": "^1.1.0",
"jsonc-eslint-parser": "^1 || ^2.0.2",
"npm-package-arg": "^8.1.5",
"semver": "^7.3.5"
}